-
Notifications
You must be signed in to change notification settings - Fork 14k
[DO NOT MERGE] Experiment with micro-optimizing push_str calls #148604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[DO NOT MERGE] Experiment with micro-optimizing push_str calls #148604
Conversation
|
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[DO NOT MERGE] Experiment with micro-optimizing push_str calls
This comment has been minimized.
This comment has been minimized.
|
@bors try cancel |
|
Try build cancelled. Cancelled workflows: |
f04df73 to
226e775
Compare
|
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[DO NOT MERGE] Experiment with micro-optimizing push_str calls
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
226e775 to
36de490
Compare
|
@bors try cancel |
|
Try build cancelled. Cancelled workflows: |
|
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[DO NOT MERGE] Experiment with micro-optimizing push_str calls
|
Btw, you don't need to cancel the previous try build when making a new one. Bors will automatically cancel the previous one. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This comment has been minimized.
This comment has been minimized.
|
Huh. CI failed but the try build didn't, is this another case of a check only being run in CI, or did something about bors change so that perf can continue even if there's an issue? |
|
Finished benchmarking commit (978d49e): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -5.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 475.185s -> 474.535s (-0.14%) |
|
It's a very slight improvement by every metric, including artifact size, surprisingly. I think I might open an ACP for |
|
The default try build just builds the compiler, and doesn't run any tests. So often it succeeds even if CI fails, it's by design. |
|
FWIW, the artifact size is noise, and the icount results are a wash. It doesn't seem to me that this has an effect. |
No description provided.